linux-kernel - Re: [v6 3/4] mpt3sas:Fix driver modifying persistent data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181030133442.GC41022@google.com>
Date:   Tue, 30 Oct 2018 08:34:42 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Suganath Prabu <suganath-prabu.subramani@...adcom.com>
Cc:     lukas@...ner.de, linux-scsi@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        benh@...nel.crashing.org, ruscur@...sell.cc,
        sbobroff@...ux.ibm.com, oohall@...il.com,
        andy.shevchenko@...il.com, Sathya.Prakash@...adcom.com,
        sreekanth.reddy@...adcom.com
Subject: Re: [v6 3/4] mpt3sas:Fix driver modifying persistent data.

On Tue, Oct 23, 2018 at 03:51:20PM +0530, Suganath Prabu wrote:
> * If EEDPTagMode field in manufacturing page11 is set,
> unset it. This is needed to fix a hardware bug
> in SAS3/SAS2 cards, So, skipping EEDPTagMode changes
> in Manufacturing page11 for SAS35 controllers.
> 
> * Fix driver modifying NVRAM/persistent data in
> Manufacturing page11 along with current copy. Driver should
> change only current copy of Manufacturing page11.

These *look* like two separate changes that should be in separate patches.

Also, fix your subject line so "git log --oneline drivers/scsi/mpt3sas"
looks nice  This subject line is missing a space in "mpt3sas:Fix"

Bjorn