linux-kernel - Re: [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50a9c2d1-abc5-b04f-1f95-878f216a47b1@grimberg.me>
Date:   Tue, 30 Oct 2018 17:37:59 -0700
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping


>   static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
> +						     unsigned int flags,
>   						     unsigned int cpu)
>   {
>   	struct blk_mq_tag_set *set = q->tag_set;
> @@ -84,7 +85,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
>   							  unsigned int hctx_type,
>   							  unsigned int cpu)
>   {
> -	return blk_mq_map_queue(q, cpu);
> +	return blk_mq_map_queue(q, hctx_type, cpu);
>   }

Haven't read through the rest of the patch set, but it looks a bit
strange that a type enumeration is being passed on as flags field.