linux-kernel - Re: [PATCH 07/16] blk-mq: support multiple hctx maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4164e35e-1361-7ea1-f2c1-f9eea7030df9@kernel.dk>
Date:   Wed, 31 Oct 2018 08:23:09 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Sagi Grimberg <sagi@...mberg.me>, linux-block@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/16] blk-mq: support multiple hctx maps

On 10/30/18 6:59 PM, Sagi Grimberg wrote:
>> +static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
>> +						     unsigned int flags,
>> +						     unsigned int cpu)
>>   {
>> -	return blk_mq_map_queue(q, hctx_type, cpu);
>> +	int hctx_type = 0;
>> +
>> +	if (q->mq_ops->flags_to_type)
>> +		hctx_type = q->mq_ops->flags_to_type(q, flags);
> 
> nitpick: I think that rq_flags_to_type is a bit more descriptive here.
> just a personal opinion.

Sure, I can make that change.

-- 
Jens Axboe