linux-kernel - Re: [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7dc22ab-73b5-f869-07b5-51ddf7d795dd@kernel.dk>
Date:   Wed, 31 Oct 2018 08:21:34 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Sagi Grimberg <sagi@...mberg.me>, linux-block@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx
 directory

On 10/30/18 6:53 PM, Sagi Grimberg wrote:
> 
>> It can be useful for a user to verify what type a given hardware
>> queue is, expose this information in sysfs.
> 
> I assume the user is expected to understand the meaning of the
> enumeration it sees in accessing this field correct?
> 
> Would be nice to output some meaningful string but I'm not
> yet sure how to do that, but would be nice...

The type is driver private, there's no specific meaning associated
with the type. We could make it output a string provided that
the driver had a way to query it. For now I think the type is
enough, it'll allow you to see which ones are different.

> Other than that,
> Reviewed-by: Sagi Grimberg <sagi@...mberg.me>

Thanks

-- 
Jens Axboe