linux-kernel - Re: [Outreachy kernel] Re: [PATCH] drm: Remove 80-column line in drm_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Oct 2018 14:36:42 -0300
From:   Shayenne Moura <shayenneluzmoura@...il.com>
To:     Daniel Vetter <daniel.vetter@...ll.ch>
Cc:     "Nikula, Jani" <jani.nikula@...ux.intel.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Sean Paul <sean@...rly.run>, Dave Airlie <airlied@...ux.ie>,
        outreachy-kernel@...glegroups.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [Outreachy kernel] Re: [PATCH] drm: Remove 80-column line in
 drm_mode_object.c

On 10/31, Daniel Vetter wrote:
> On Wed, Oct 31, 2018 at 4:13 PM Jani Nikula <jani.nikula@...ux.intel.com> wrote:
> >
> > On Wed, 31 Oct 2018, Shayenne da Luz Moura <shayenneluzmoura@...il.com> wrote:
> > > Add a new variable to make the drm_mode_object comparison before
> > > idr_alloc and decrease line size.
> > >
> > > Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@...il.com>
> > > ---
> > >  drivers/gpu/drm/drm_mode_object.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_mode_object.c b/drivers/gpu/drm/drm_mode_object.c
> > > index be8b754eaf60..4b9eafddb409 100644
> > > --- a/drivers/gpu/drm/drm_mode_object.c
> > > +++ b/drivers/gpu/drm/drm_mode_object.c
> > > @@ -36,9 +36,10 @@ int __drm_mode_object_add(struct drm_device *dev, struct drm_mode_object *obj,
> > >                         void (*obj_free_cb)(struct kref *kref))
> > >  {
> > >       int ret;
> > > +     struct drm_mode_object *obj_tmp = register_obj ? obj : NULL;
> > >
> > >       mutex_lock(&dev->mode_config.idr_mutex);
> > > -     ret = idr_alloc(&dev->mode_config.crtc_idr, register_obj ? obj : NULL, 1, 0, GFP_KERNEL);
> > > +     ret = idr_alloc(&dev->mode_config.crtc_idr, obj_tmp, 1, 0, GFP_KERNEL);
> >
> > Please don't send checkpatch "fixes" to adhere to the 80-column rule. Or
> > at least use --max-line-length=100 or something to look for worse
> > offenders than this.
> >
> > And if you insist, please just add a newline and proper indentation
> > after "NULL," instead of adding a temporary variable.
> 
> Breaking the line after NULL, seems reasonable, I'd be happy to merge that.
> -Daniel

Okay, I will send a new version.

Thank you!