linux-kernel - Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181101002708.GG24212@piout.net>
Date:   Thu, 1 Nov 2018 01:27:08 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race
 condition and leak

Hello,

On 31/10/2018 19:12:06-0400, Sasha Levin wrote:
> -	m->rtc = rtc_device_register(DRIVER_NAME,
> -			&m->client->dev,
> -			&menelaus_rtc_ops, THIS_MODULE);
> -	if (IS_ERR(m->rtc)) {
> +	err = rtc_register_device(m->rtc);

This appeared in v4.13, this will not compile on v3.18.

> +	if (err) {
>  		if (alarm) {
>  			menelaus_remove_irq_work(MENELAUS_RTCALM_IRQ);
>  			device_init_wakeup(&m->client->dev, 0);
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com