linux-kernel - Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Oct 2018 21:29:36 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race
 condition and leak

On Thu, Nov 01, 2018 at 01:27:08AM +0100, Alexandre Belloni wrote:
>Hello,
>
>On 31/10/2018 19:12:06-0400, Sasha Levin wrote:
>> -	m->rtc = rtc_device_register(DRIVER_NAME,
>> -			&m->client->dev,
>> -			&menelaus_rtc_ops, THIS_MODULE);
>> -	if (IS_ERR(m->rtc)) {
>> +	err = rtc_register_device(m->rtc);
>
>This appeared in v4.13, this will not compile on v3.18.

Indeed, I guess I need more cross-compilers here. Thanks!

--
Thanks,
Sasha