linux-kernel - Re: [PATCH 09/16] blk-mq: cache request hardware queue mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a12d8c2-cb16-168c-f8e2-ffe1649d6554@kernel.dk>
Date:   Thu, 1 Nov 2018 06:22:14 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Hannes Reinecke <hare@...e.de>, linux-block@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/16] blk-mq: cache request hardware queue mapping

On 11/1/18 3:27 AM, Hannes Reinecke wrote:
> On 10/30/18 7:32 PM, Jens Axboe wrote:
>> We call blk_mq_map_queue() a lot, at least two times for each
>> request per IO, sometimes more. Since we now have an indirect
>> call as well in that function. cache the mapping so we don't
>> have to re-call blk_mq_map_queue() for the same request
>> multiple times.
>>
>> Signed-off-by: Jens Axboe <axboe@...nel.dk>
>> ---
>>   block/blk-flush.c      | 12 ++++--------
>>   block/blk-mq-debugfs.c |  4 +---
>>   block/blk-mq-sched.c   |  6 ++----
>>   block/blk-mq-tag.c     |  9 +--------
>>   block/blk-mq.c         | 22 +++++++++-------------
>>   block/blk-mq.h         |  5 +----
>>   include/linux/blkdev.h |  1 +
>>   7 files changed, 19 insertions(+), 40 deletions(-)
>>
> Hehe.
> I had been wondering about this since the original mq implementation, 
> but was told not to worry :-)

To be fair, it was just an array index. Now it's got an indirect
call, so it's more expensive.
 > Reviewed-by: Hannes Reinecke <hare@...e.com>

Thanks!

-- 
Jens Axboe