linux-kernel - Re: [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b8e6d31-a406-a0c6-fd6c-7e2b876e21ab@linaro.org>
Date:   Thu, 1 Nov 2018 12:25:38 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Rohit kumar <rohitkr@...eaurora.org>, plai@...eaurora.org,
        bgoswami@...eaurora.org, lgirdwood@...il.com, broonie@...nel.org,
        perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, rohkumar@....qualcomm.com,
        niklas.cassel@...aro.org
Subject: Re: [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask



On 01/11/18 11:51, Rohit kumar wrote:
> SD line mask for MI2S starts from BIT 0 instead of BIT 1.
> Fix all bit mask for MI2S SD lines.
> 
> Signed-off-by: Rohit kumar <rohitkr@...eaurora.org>

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

> ---
>   sound/soc/qcom/qdsp6/q6afe.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
> index 000775b..829b5e987 100644
> --- a/sound/soc/qcom/qdsp6/q6afe.c
> +++ b/sound/soc/qcom/qdsp6/q6afe.c
> @@ -49,14 +49,14 @@
>   #define AFE_PORT_I2S_SD1		0x2
>   #define AFE_PORT_I2S_SD2		0x3
>   #define AFE_PORT_I2S_SD3		0x4
> -#define AFE_PORT_I2S_SD0_MASK		BIT(0x1)
> -#define AFE_PORT_I2S_SD1_MASK		BIT(0x2)
> -#define AFE_PORT_I2S_SD2_MASK		BIT(0x3)
> -#define AFE_PORT_I2S_SD3_MASK		BIT(0x4)
> -#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(2, 1)
> -#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(4, 3)
> -#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(3, 1)
> -#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(4, 1)
> +#define AFE_PORT_I2S_SD0_MASK		BIT(0x0)
> +#define AFE_PORT_I2S_SD1_MASK		BIT(0x1)
> +#define AFE_PORT_I2S_SD2_MASK		BIT(0x2)
> +#define AFE_PORT_I2S_SD3_MASK		BIT(0x3)
> +#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(1, 0)
> +#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(3, 2)
> +#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(2, 0)
> +#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(3, 0)
>   #define AFE_PORT_I2S_QUAD01		0x5
>   #define AFE_PORT_I2S_QUAD23		0x6
>   #define AFE_PORT_I2S_6CHS		0x7
>