linux-kernel - Re: [PATCH v2] x86/kvmclock : convert to SPDX identifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Nov 2018 16:28:56 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Peng Hao <penghao122@...a.com.cn>
cc:     rkrcmar@...hat.com, pbonzini@...hat.com, x86@...nel.org,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Peng Hao <peng.hao2@....com.cn>
Subject: Re: [PATCH v2] x86/kvmclock : convert to SPDX identifiers

Peng,

On Thu, 1 Nov 2018, Peng Hao wrote:

> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text

Again:

 git grep 'This patch' Documentation/process/

This leads you to:

 "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour."

Documentation is there for a reason.

IOW, writing 'This patch does ....' is not the proper way for writing a
changelog. It's entirely clear that this is a patch. No need to mention
it. Imperative mood means something like this:

Replace the verbose license text with the matching SPDX license identifier.

Thanks,

	tglx