linux-kernel - Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154116100076.30246.13155169401499183452@skylake-alporthouse-com>
Date:   Fri, 02 Nov 2018 12:16:40 +0000
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Robert Foss <robert.foss@...labora.com>, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        robdclark@...il.com
Cc:     Robert Foss <robert.foss@...labora.com>
Subject: Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

Quoting Robert Foss (2018-11-02 12:13:13)
> If dma_fence_wait fails to wait for a supplied in-fence in
> msm_ioctl_gem_submit, make sure we release that in-fence.
> 
> Also remove this dma_fence_put() from the 'out' label.
> 
> Signed-off-by: Robert Foss <robert.foss@...labora.com>

Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>

Rob, this probably merits a cc:stable tag -- if the wait was interrupted
by a signal, the fence would be leaked.
-Chris