linux-kernel - Re: Crash report: Broken NUMA distance map causes crash on arm64 system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Nov 2018 13:19:58 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     John Garry <john.garry@...wei.com>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Linuxarm <linuxarm@...wei.com>, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: Crash report: Broken NUMA distance map causes crash on arm64
 system

On Fri, Nov 02, 2018 at 12:08:53PM +0000, John Garry wrote:
> > @@ -1337,7 +1353,7 @@ void sched_init_numa(void)
> >  	int level = 0;
> >  	int i, j, k;
> > 
> > -	sched_domains_numa_distance = kzalloc(sizeof(int) * nr_node_ids, GFP_KERNEL);
> > +	sched_domains_numa_distance = kzalloc(sizeof(int) * (nr_node_ids + 1), GFP_KERNEL);
> 
> Ahhhh, unfortuately this change in isolation is not fixing the crash for me.
> I'm still crashing in the same place repeatedly.

Hurm.. sadness, means my reproduces doesn't reproduce quite enough :/
I'll see if I can somehow get something better going.