linux-kernel - Re: [PATCH] mremap: properly flush TLB before releasing the page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjTM5588YwhAYQiH7fCu0itRjHYJZ8WaG1y_bx=6JUhtQ@mail.gmail.com>
Date:   Fri, 2 Nov 2018 09:05:17 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     kirill@...temov.name
Cc:     Jann Horn <jannh@...gle.com>, will.deacon@....com,
        Greg KH <gregkh@...uxfoundation.org>, stable@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>, linux-mm@...ck.org,
        mhocko@...nel.org, hughd@...gle.com
Subject: Re: [PATCH] mremap: properly flush TLB before releasing the page

On Fri, Nov 2, 2018 at 8:25 AM Kirill A. Shutemov <kirill@...temov.name> wrote:
>
> I wounder if it would be cheaper to fix this by taking i_mmap_lock_write()
> unconditionally in mremap() path rather than do a lot of flushing.

That wouldn't help. Think anonymous pages and try_to_free() rmap walk.
So then I think we'd have to take the anonvma lock or something.

And it's not like we are likely to even do any more flushes, really.
We don't flush for each page, only for each page table. So every 512
pages or so.

                     Linus