linux-kernel - Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Nov 2018 09:07:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     jacopo mondi <jacopo@...ndi.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Magnus Damm <magnus.damm@...il.com>,
        linux-mtd@...ts.infradead.org, linux-sh@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops
 build warning

On 11/2/18 12:52 AM, jacopo mondi wrote:
> Hi Randy,
>    thanks for the patch.
> 
> On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
>> <mtd/onenand.h>, and doing so causes a build warning, so drop
>> that header file.
>>
>> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
>> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
>>      struct mtd_oob_ops *ops);
>>
>> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
> 
> Not sure if this is worth pointing out, but this commit only resorts
> headers. The one introducing the warning is actually 33893d7aa.
> 
> I felt like reporting this, as introducing a "Fixes" line for that
> commit too would help backporting maybe?

Oops, thanks, I'll fix that and send a v2 with your Ack.

> In any case:
> Acked-by: Jacopo Mondi <jacopo@...ndi.org>
> 
> Thanks
>    j
> 
>>
>> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Suggested-by: Miquel Raynal <miquel.raynal@...tlin.com>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
>> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>> Cc: Rich Felker <dalias@...c.org>
>> Cc: Jacopo Mondi <jacopo+renesas@...ndi.org>
>> Cc: Magnus Damm <magnus.damm@...il.com>
>> Cc: linux-mtd@...ts.infradead.org
>> Cc: linux-sh@...r.kernel.org
>> ---
>>  arch/sh/boards/mach-kfr2r09/setup.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
>> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
>> @@ -25,7 +25,6 @@
>>  #include <linux/memblock.h>
>>  #include <linux/mfd/tmio.h>
>>  #include <linux/mmc/host.h>
>> -#include <linux/mtd/onenand.h>
>>  #include <linux/mtd/physmap.h>
>>  #include <linux/platform_data/lv5207lp.h>
>>  #include <linux/platform_device.h>
>>
>>


-- 
~Randy