linux-kernel - Re: [PATCH] include/asm/cmpxchg.h: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqt6zboDwTNUkvhRi2s=LUnqhvXoHtGQFkrUrW+2bCEb=5RRQ@mail.gmail.com>
Date:   Sat, 3 Nov 2018 00:43:18 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Matt Turner <mattst88@...il.com>
Cc:     mcree@...on.net.nz, Brajeswar Ghosh <brajeswar.linux@...il.com>,
        rth@...ddle.net, ink@...assic.park.msu.ru, parri.andrea@...il.com,
        mingo@...nel.org, paulmck@...ux.vnet.ibm.com,
        linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>
Subject: Re: [PATCH] include/asm/cmpxchg.h: Remove duplicate header

On Sat, Nov 3, 2018 at 12:31 AM Matt Turner <mattst88@...il.com> wrote:
>
> On Fri, Nov 2, 2018 at 11:55 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
> > We run the static analyser "make includecheck" which list out files where
> > duplicate headers can be removed and based on that we thought to remove
> > from this file. Didn't understood about the existence of second include ??
>
>
> #define ____xchg(type, args...)         __xchg ## type ## _local(args)
> #define ____cmpxchg(type, args...)      __cmpxchg ## type ## _local(args)
> #include <asm/xchg.h>
> [snip]
> #undef ____xchg
> #undef ____cmpxchg
> #define ____xchg(type, args...)         __xchg ##type(args)
> #define ____cmpxchg(type, args...)      __cmpxchg ##type(args)
> #include <asm/xchg.h>
>
> asm/xchg.h has a comment at the top that says
>
> /*
>  * xchg/xchg_local and cmpxchg/cmpxchg_local share the same code
>  * except that local version do not have the expensive memory barrier.
>  * So this file is included twice from asm/cmpxchg.h.
>  */

Thanks Matt. Sorry for the noise.
Is there any way to exclude it from static analyser that someone else will
not do the same mistake in future ?