linux-kernel - Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Open Source and information security mailing list archives

Message-ID: <0298f7ec-fbff-8edb-92bb-70a736ddaf25@mentor.com>
Date:   Mon, 5 Nov 2018 10:58:30 +0200
From:   Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
To:     Shawn Guo <shawnguo@...nel.org>, Martin Kaiser <martin@...ser.cx>,
        Clément Péron <peron.clem@...il.com>
CC:     Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        NXP Linux Team <linux-imx@....com>,
        Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Adding Clément.

On 11/04/2018 04:46 PM, Shawn Guo wrote:
> On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
>> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
>> function blocks. Add their ipg and per clocks to the device tree.
>>
>> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> 
> Are these EPIT devices actually used in upstream kernel, or just
> somewhere else?

Clément wrote a good driver, which has already passed a series of reviews,
but this clocks add-on is actually missing.

Clément, can you please add clock-names property and the corresponding
functional change to your driver? Thank you in advance.

--
Best wishes,
Vladimir

>> ---
>>
>> I tried to make this similar to gpt1 and gpt2.
>>
>>  arch/arm/boot/dts/imx25.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
>> index b25309d26ea5..e80101847aff 100644
>> --- a/arch/arm/boot/dts/imx25.dtsi
>> +++ b/arch/arm/boot/dts/imx25.dtsi
>> @@ -388,12 +388,16 @@
>>  			epit1: timer@...94000 {
>>  				compatible = "fsl,imx25-epit";
>>  				reg = <0x53f94000 0x4000>;
>> +				clocks = <&clks 83>, <&clks 43>;
>> +				clock-names = "ipg", "per";
>>  				interrupts = <28>;
>>  			};
>>  
>>  			epit2: timer@...98000 {
>>  				compatible = "fsl,imx25-epit";
>>  				reg = <0x53f98000 0x4000>;
>> +				clocks = <&clks 84>, <&clks 43>;
>> +				clock-names = "ipg", "per";
>>  				interrupts = <27>;
>>  			};
>>  
>> -- 
>> 2.1.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives