linux-kernel - Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181105091230.z2ooz7olbdpopxyd@viti.kaiser.cx>
Date:   Mon, 5 Nov 2018 10:12:30 +0100
From:   Martin Kaiser <martin@...ser.cx>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        NXP Linux Team <linux-imx@....com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks

Hi,

Thus wrote Shawn Guo (shawnguo@...nel.org):

> On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
> > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
> > function blocks. Add their ipg and per clocks to the device tree.

> > Signed-off-by: Martin Kaiser <martin@...ser.cx>

> Are these EPIT devices actually used in upstream kernel, or just
> somewhere else?

Until I saw Vladimir's mail this morning, I wasn't aware of any mainline
driver that's using the EPIT devices. I found that the clocks are
missing when I tried to use EPIT with a company-internal driver that's
not suitable for mainline integration.

Still, I think that merging this patch does no harm. If the EPIT devices
are present in the DT, we should add all resources they're using.

Thanks & best regards,

   Martin