linux-kernel - Re: [PATCH] block: respect virtual boundary mask in bvecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c15244a4-9085-5255-edea-b92a9ed1307c@suse.de>
Date:   Tue, 6 Nov 2018 15:56:00 +0100
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Bart Van Assche <bvanassche@....org>, Jens Axboe <axboe@...com>
Cc:     Linux Block Layer Mailinglist <linux-block@...r.kernel.org>,
        Hannes Reinecke <hare@...e.de>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Jan Kara <jack@...e.cz>, Sagi Grimberg <sagi@...mberg.me>
Subject: Re: [PATCH] block: respect virtual boundary mask in bvecs

On 06/11/2018 15:53, Bart Van Assche wrote:
> How about changing that expression into the following to make it easier
> for the compiler to optimize this code?
> 
> (offset | (bprv->bv_offset + bprv->bv_len)) & queue_virt_boundary(q)

Uhm I have to admit I'm not really able to parse the above expression.
Sure GCC will do it but I think it's less readable (at least for me).
Let's see what other's think.

Thanks,
	Johannes
-- 
Johannes Thumshirn                                        SUSE Labs
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850