[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87tvktqedf.fsf@concordia.ellerman.id.au>
Date: Wed, 07 Nov 2018 23:08:28 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: frowand.list@...il.com, Rob Herring <robh+dt@...nel.org>,
Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Alan Tull <atull@...nel.org>, Moritz Fischer <mdf@...nel.org>
Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
devicetree@...r.kernel.org, linux-fpga@...r.kernel.org
Subject: Re: [PATCH v6 07/18] of: dynamic: change type of of_{at,de}tach_node() to void
frowand.list@...il.com writes:
> From: Frank Rowand <frank.rowand@...y.com>
>
> of_attach_node() and of_detach_node() always return zero, so
> their return value is meaningless.
But should they always return zero?
At least __of_attach_node_sysfs() can fail in several ways.
And there's also this in __of_detach_node() which should probably be
returning an error:
if (WARN_ON(of_node_check_flag(np, OF_DETACHED)))
return;
Seems to me we should instead be fixing these to propagate errors,
rather than hiding them?
cheers
Powered by blists - more mailing lists