linux-kernel - RE: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916B318947B803BC5ADF4A6F5C50@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Thu, 8 Nov 2018 01:24:51 +0000
From:   Anson Huang <anson.huang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

Hi, Fabio

Best Regards!
Anson Huang

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@...il.com]
> Sent: 2018年11月7日 18:03
> To: Anson Huang <anson.huang@....com>
> Cc: Rob Herring <robh+dt@...nel.org>; Mark Rutland
> <mark.rutland@....com>; Shawn Guo <shawnguo@...nel.org>; Sascha
> Hauer <s.hauer@...gutronix.de>; Sascha Hauer <kernel@...gutronix.de>;
> Fabio Estevam <fabio.estevam@....com>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; linux-kernel
> <linux-kernel@...r.kernel.org>; moderated list:ARM/FREESCALE IMX / MXC
> ARM ARCHITECTURE <linux-arm-kernel@...ts.infradead.org>; dl-linux-imx
> <linux-imx@....com>
> Subject: Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support
> 
> Hi Anson,
> 
> On Wed, Nov 7, 2018 at 3:19 AM Anson Huang <anson.huang@....com>
> wrote:
> 
> > +&fec2 {
> > +       pinctrl-0 = <&pinctrl_enet2>;
> > +       /delete-property/pinctrl-assert-gpios;
> 
> "pinctrl-assert-gpios" does not exist in mainline, so not sure why you are
> deleting it.

Regarding the fec2 settings in imx7d-sdb.dts, originally it uses Rev-A board (but some nodes are
using Rev-B board), in this patch, I clean up all the settings in imx7d-sdb.dts using Rev-B board,
so below is added to imx7d-sdb.dts for Rev-B board, and in imx7d-sdb-reva.dts I have to
delete it, since Rev-A board has no this pin.

-	pinctrl-0 = <&pinctrl_enet2>;
+	pinctrl-0 = <&pinctrl_enet2 &pinctrl_enet2_epdc0_en>;
+	pinctrl-assert-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;
 
Anson.