linux-kernel - Re: [PATCH v1 2/4] thermal: tegra: remove unnecessary warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181108124716.GE1340@ulmo>
Date:   Thu, 8 Nov 2018 13:47:16 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Wei Ni <wni@...dia.com>
Cc:     daniel.lezcano@...aro.org, linux-tegra@...r.kernel.org,
        rui.zhang@...el.com, edubezval@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/4] thermal: tegra: remove unnecessary warnings

On Mon, Nov 05, 2018 at 05:32:32PM +0800, Wei Ni wrote:
> Convert warnings to info as not all platforms may
> have all the thresholds and sensors enabled.
> 
> Signed-off-by: Wei Ni <wni@...dia.com>
> ---
>  drivers/thermal/tegra/soctherm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

This seems overly generalized to me. Shouldn't we be checking in a more
fine-grained way for the absence of thresholds and/or sensors?

Otherwise, how are going to make the difference between the sensor not
being enabled or the device tree just missing the information?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)