linux-kernel - Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69b1d0d9-5a5b-e11d-4ebe-eb49b9ba2ef3@sandeen.net>
Date:   Fri, 9 Nov 2018 17:45:21 -0600
From:   Eric Sandeen <sandeen@...deen.net>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>,
        hmsjwzb <weizhefix@...il.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c



On 11/9/18 5:40 PM, Darrick J. Wong wrote:
> On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote:
> 
> Sorry, but all submissions must have a Signed-off-by: to be reviewed.
> 
> Also, there's no To: header on this message??

Also, it's not the only misspelling, and not even the only instance of
"auxillary" in the xfs codebase ... generally we only fix up such things
when we're touching surrounding code for a more substantive change.

-Eric

> NAK.
> 
> --D
> 
>> ---
>>  fs/xfs/kmem.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c
>> index fdd9d6ede25c..73ec1f84e591 100644
>> --- a/fs/xfs/kmem.c
>> +++ b/fs/xfs/kmem.c
>> @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags)
>>  		return ptr;
>>  
>>  	/*
>> -	 * __vmalloc() will allocate data pages and auxillary structures (e.g.
>> +	 * __vmalloc() will allocate data pages and auxiliary structures (e.g.
>>  	 * pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context
>>  	 * here. Hence we need to tell memory reclaim that we are in such a
>>  	 * context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering
>> -- 
>> 2.17.1
>>
>