linux-kernel - Re: Re: [PATCH V3] binder: ipc namespace support for android binder(Internet mail)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHRSSEwjNYu1345KFvkTTvvy6Qb+T6=4WXEZ-t8wcGtkCUa_UA@mail.gmail.com>
Date:   Fri, 9 Nov 2018 21:24:29 -0800
From:   Todd Kjos <tkjos@...gle.com>
To:     chouryzhou@...cent.com
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>, akpm@...ux-foundation.org,
        dave@...olabs.net,
        "open list:ANDROID DRIVERS" <devel@...verdev.osuosl.org>,
        LKML <linux-kernel@...r.kernel.org>, chouryzhou@...il.com
Subject: Re: Re: [PATCH V3] binder: ipc namespace support for android
 binder(Internet mail)

On Fri, Nov 9, 2018 at 8:43 PM chouryzhou(周威) <chouryzhou@...cent.com> wrote:

>
> If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists,  it will be a static
> reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by me) with
> no namespace-ization. You will get the same one in all processes, everything is
> the same as  without this patch.

except, as far as I can tell, binder_init_ns() would never have been
called on it so the mutex and list heads are not initialized so its
completely broken. Am I missing something? How do those fields get
initialized in this case?

>
> - choury -
>