linux-kernel - Re: Re: [PATCH V3] binder: ipc namespace support for android binder(Internet mail)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5FBCBE569E134E4CA167B91C0A77FD610198F8A65C@EXMBX-SZMAIL022.tencent.com>
Date:   Sat, 10 Nov 2018 05:43:30 +0000
From:   chouryzhou(周威) <chouryzhou@...cent.com>
To:     tkjos <tkjos@...gle.com>
CC:     gregkh <gregkh@...uxfoundation.org>, arve <arve@...roid.com>,
        tkjos <tkjos@...roid.com>, akpm <akpm@...ux-foundation.org>,
        dave <dave@...olabs.net>, devel <devel@...verdev.osuosl.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        chouryzhou <chouryzhou@...il.com>
Subject: Re: Re: [PATCH V3] binder: ipc namespace support for android
 binder(Internet mail)

> >
> > If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists,  it will be a static
> > reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by me) with
> > no namespace-ization. You will get the same one in all processes, everything is
> > the same as  without this patch.
> 
> except, as far as I can tell, binder_init_ns() would never have been
> called on it so the mutex and list heads are not initialized so its
> completely broken. Am I missing something? How do those fields get
> initialized in this case?

> @@ -5832,8 +5888,12 @@ static int __init binder_init(void)
>                         goto err_init_binder_device_failed;
>         }
>
> -       return ret;
> +       ret = binder_init_ns(&init_ipc_ns);
> +       if (ret)
> +               goto err_init_namespace_failed;
>
> +       return ret;

They are initialized here.

- choury -