[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 11 Nov 2018 12:29:44 +0100
From: Pavel Machek <pavel@....cz>
To: Dan O'Donovan <dan@...tex.com>
Cc: linux-kernel@...r.kernel.org,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Lee Jones <lee.jones@...aro.org>,
Linus Walleij <linus.walleij@...aro.org>,
Jacek Anaszewski <jacek.anaszewski@...il.com>,
linux-gpio@...r.kernel.org, linux-leds@...r.kernel.org,
Carlos Iglesias <carlos.iglesias@...tex.com>
Subject: Re: [PATCH v3 1/3] mfd: upboard: Add UP2 platform controller driver
Hi!
> +static void __reg_io_start(const struct upboard_ddata * const ddata)
> +{
> + /*
> + * CLEAR signal must be pulsed low before any register access.
> + * This resets internal counters in the controller and marks
> + * the start of a new register access.
> + */
> + set_clear(ddata, 0);
> + set_clear(ddata, 1);
> +}
We normally reserve __ prefix for different stuff. This is not using
it appropriately.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists