[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 11 Nov 2018 11:29:01 -0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Huacai Chen <chenhc@...ote.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>,
Sudeep Holla <sudeep.holla@....com>,
linux-kernel@...r.kernel.org, Fuxin Zhang <zhangfx@...ote.com>,
Zhangjin Wu <wuzhangjin@...il.com>,
Huacai Chen <chenhuacai@...il.com>
Subject: Re: [PATCH V2] cacheinfo: Keep the old value if of_property_read_u32
fails
On Fri, Oct 19, 2018 at 09:31:29PM +0800, Huacai Chen wrote:
> Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
> property_read_u32 instead of get_property,read_number") makes cache
> size and number_of_sets be 0 if DT doesn't provide there values. I
> think this is unreasonable so make them keep the old values, which is
> the same as old kernels.
>
> Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")
> Signed-off-by: Huacai Chen <chenhc@...ote.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> ---
> drivers/base/cacheinfo.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
What changed from v1? Always put that below the --- line.
Please fix this up and resend a v3.
thanks,
greg k-h
Powered by blists - more mailing lists