linux-kernel - Re: [PATCH V2] cacheinfo: Keep the old value if of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H72Yf86sEBykk=ziAr+6+ttT=GRWK5DnyFpNFqccoAahQ@mail.gmail.com>
Date:   Mon, 12 Nov 2018 10:52:39 +0800
From:   Huacai Chen <chenhc@...ote.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Sudeep Holla <sudeep.holla@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        zhangfx <zhangfx@...ote.com>, wu zhangjin <wuzhangjin@...il.com>
Subject: Re: [PATCH V2] cacheinfo: Keep the old value if of_property_read_u32 fails

On Mon, Nov 12, 2018 at 3:29 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Fri, Oct 19, 2018 at 09:31:29PM +0800, Huacai Chen wrote:
> > Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
> > property_read_u32 instead of get_property,read_number") makes cache
> > size and number_of_sets be 0 if DT doesn't provide there values. I
> > think this is unreasonable so make them keep the old values, which is
> > the same as old kernels.
> >
> > Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")
> > Signed-off-by: Huacai Chen <chenhc@...ote.com>
> > Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> > ---
> >  drivers/base/cacheinfo.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
>
> What changed from v1?  Always put that below the --- line.
Hi, Greg,

V2 just add a Fixes line and Reviewed-by line, no functional changes.

Huacai
>
> Please fix this up and resend a v3.
>
> thanks,
>
> greg k-h