linux-kernel - Re: [RFC][PATCH 04/12] PGPLIB: Basic packet parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19257.1542025917@warthog.procyon.org.uk>
Date:   Mon, 12 Nov 2018 12:31:57 +0000
From:   David Howells <dhowells@...hat.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>
Cc:     dhowells@...hat.com, dwmw2@...radead.org,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        silviu.vlasceanu@...wei.com
Subject: Re: [RFC][PATCH 04/12] PGPLIB: Basic packet parser

Roberto Sassu <roberto.sassu@...wei.com> wrote:

> +	size_t size, datalen = *_datalen;
> ...
> +	if ((int)size < 0)
> +		goto too_big;

Hmmm...  "if (size > INT_MAX)" is probably better.

David