linux-kernel - Re: [PATCH] misc: genwqe: remove duplicated include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2fccbaf463b4adabe06937840627d844@linux.vnet.ibm.com>
Date:   Mon, 12 Nov 2018 12:29:02 +0100
From:   haver <haver@...ux.vnet.ibm.com>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     gregkh@...uxfoundation.org, gpiccoli@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: genwqe: remove duplicated include file

On 2018-09-20 07:07, zhong jiang wrote:
> module.h has duplicated include. hence just remove
> redundant include file.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/misc/genwqe/card_base.c | 1 -
>  drivers/misc/genwqe/card_ddcb.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c 
> b/drivers/misc/genwqe/card_base.c
> index c7cd367..d137d0fa 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -24,7 +24,6 @@
>   * controlled from here.
>   */
> 
> -#include <linux/module.h>
>  #include <linux/types.h>
>  #include <linux/pci.h>
>  #include <linux/err.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c 
> b/drivers/misc/genwqe/card_ddcb.c
> index 656449c..9a65bd9 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -27,7 +27,6 @@
>   */
> 
>  #include <linux/types.h>
> -#include <linux/module.h>
>  #include <linux/sched.h>
>  #include <linux/wait.h>
>  #include <linux/pci.h>

Signed-off-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>