linux-kernel - Re: [PATCH] svm: Add mutex_lock to protect apic_access_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181112133731.lwje2hzibd64cvc3@8bytes.org>
Date:   Mon, 12 Nov 2018 14:37:32 +0100
From:   "joro@...tes.org" <joro@...tes.org>
To:     "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        Wei Wang <wawei@...zon.de>,
        Amadeusz Juskowiak <ajusk@...zon.de>,
        Julian Stecklina <jsteckli@...zon.de>
Subject: Re: [PATCH] svm: Add mutex_lock to protect apic_access_page_done on
 AMD systems

On Mon, Nov 12, 2018 at 12:23:14PM +0000, Suthikulpanit, Suravee wrote:
> From: Wei Wang <wawei@...zon.de>
> 
> There is a race condition when accessing kvm->arch.apic_access_page_done.
> Due to it, x86_set_memory_region will fail when creating the second vcpu
> for a svm guest.
> 
> Add a mutex_lock to serialize the accesses to apic_access_page_done.
> This lock is also used by vmx for the same purpose.
> 
> Signed-off-by: Wei Wang <wawei@...zon.de>
> Signed-off-by: Amadeusz Juskowiak <ajusk@...zon.de>
> Signed-off-by: Julian Stecklina <jsteckli@...zon.de>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>

Reviewed-by: Joerg Roedel <jroedel@...e.de>