linux-kernel - Re: [PATCH] svm: Add mutex_lock to protect apic_access_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70cc4362-5a95-d6ec-fccf-4cbe3b03bdc9@redhat.com>
Date:   Sun, 25 Nov 2018 18:34:41 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     "joro@...tes.org" <joro@...tes.org>,
        "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        Wei Wang <wawei@...zon.de>,
        Amadeusz Juskowiak <ajusk@...zon.de>,
        Julian Stecklina <jsteckli@...zon.de>
Subject: Re: [PATCH] svm: Add mutex_lock to protect apic_access_page_done on
 AMD systems

On 12/11/18 14:37, joro@...tes.org wrote:
> On Mon, Nov 12, 2018 at 12:23:14PM +0000, Suthikulpanit, Suravee wrote:
>> From: Wei Wang <wawei@...zon.de>
>>
>> There is a race condition when accessing kvm->arch.apic_access_page_done.
>> Due to it, x86_set_memory_region will fail when creating the second vcpu
>> for a svm guest.
>>
>> Add a mutex_lock to serialize the accesses to apic_access_page_done.
>> This lock is also used by vmx for the same purpose.
>>
>> Signed-off-by: Wei Wang <wawei@...zon.de>
>> Signed-off-by: Amadeusz Juskowiak <ajusk@...zon.de>
>> Signed-off-by: Julian Stecklina <jsteckli@...zon.de>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> Reviewed-by: Joerg Roedel <jroedel@...e.de>

Queued, thanks.

Paolo