linux-kernel - Re: [PATCH] spi: lpspi: Add Slave Mode support for LPSPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181113185553.GH2089@sirena.org.uk>
Date:   Tue, 13 Nov 2018 10:55:53 -0800
From:   Mark Brown <broonie@...nel.org>
To:     Clark Wang <xiaoning.wang@....com>
Cc:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: lpspi: Add Slave Mode support for LPSPI

On Mon, Nov 12, 2018 at 06:47:08AM +0000, Clark Wang wrote:

This looks fine so I'll apply it but it would have been easier to review
if it were split up a bit.  There's mechanical changes like:

> -static int lpspi_prepare_xfer_hardware(struct spi_master *master)
> +static int lpspi_prepare_xfer_hardware(struct spi_controller *controller)
>  {

...the conversion to controller...

> -	temp = fsl_lpspi->txfifosize >> 1 | (fsl_lpspi->rxfifosize >> 1) << 16;
> +	temp = fsl_lpspi->watermark >> 1 | (fsl_lpspi->watermark >> 1) << 16;

...and this renaming which could be done separately.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)