linux-kernel - Re: [PATCH] drivers/scsi/fnic/fnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1542125473.3042.6.camel@linux.vnet.ibm.com>
Date:   Tue, 13 Nov 2018 08:11:13 -0800
From:   James Bottomley <jejb@...ux.vnet.ibm.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>,
        John Garry <john.garry@...wei.com>,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        satishkh@...co.com, sebaddel@...co.com, kartilak@...co.com,
        martin.petersen@...cle.com
Cc:     jrdr.linux@...il.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, brajeswar.linux@...il.com
Subject: Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

On Tue, 2018-11-13 at 16:53 +0100, Johannes Thumshirn wrote:
> On 13/11/2018 16:44, John Garry wrote:
> > On 13/11/2018 15:08, Sabyasachi Gupta wrote:
[...]
> > > -    fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages *
> > > PAGE_SIZE));
> > > +    fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages *
> > > +                                PAGE_SIZE));
> > 
> > If you remove the extra brackets in vzalloc() argument then you may
> > not spill onto the next line.
> 
> And remove the unnecessary cast. vzalloc() (just like vmalloc())
> returns a void*, so no reason to cast it.

This is incorrect advice: there's no need to cast it to other *pointer*
types, but if you cast it to a non-pointer type (which this is doing)
the compiler will complain if there is no explicit cast.

James