linux-kernel - Re: [PATCH] drivers/scsi/fnic/fnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c58db296-87ec-5aaf-f6ce-1115d5d2a2c1@suse.de>
Date:   Tue, 13 Nov 2018 17:16:26 +0100
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     James Bottomley <jejb@...ux.vnet.ibm.com>,
        John Garry <john.garry@...wei.com>,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        satishkh@...co.com, sebaddel@...co.com, kartilak@...co.com,
        martin.petersen@...cle.com
Cc:     jrdr.linux@...il.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, brajeswar.linux@...il.com
Subject: Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

On 13/11/2018 17:11, James Bottomley wrote:
> This is incorrect advice: there's no need to cast it to other *pointer*
> types, but if you cast it to a non-pointer type (which this is doing)
> the compiler will complain if there is no explicit cast.

Right, sorry for that and thanks for spotting it James.

Byte,
	Johannes
-- 
Johannes Thumshirn                                        SUSE Labs
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850