linux-kernel - Re: [PATCH 1/3] regulator: dt-bindings: add MCP16502 regulator bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181113173036.GA2089@sirena.org.uk>
Date:   Tue, 13 Nov 2018 09:30:37 -0800
From:   Mark Brown <broonie@...nel.org>
To:     Andrei.Stefanescu@...rochip.com
Cc:     lgirdwood@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        gregkh@...uxfoundation.org, Nicolas.Ferre@...rochip.com,
        Cristian.Birsan@...rochip.com, Claudiu.Beznea@...rochip.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] regulator: dt-bindings: add MCP16502 regulator
 bindings

On Tue, Nov 13, 2018 at 11:29:24AM +0000, Andrei.Stefanescu@...rochip.com wrote:

> +- lpm-gpio: GPIO for LPM pin. Note that this GPIO *must* remain high during
> +	     suspend-to-ram, keeping the PMIC into HIBERNATE mode.

All GPIO properties should be -gpios even if they can only ever have one
GPIO.

> +- regulators: A node that houses a sub-node for each regulator within
> +              the device. Each sub-node is identified using the node's
> +              name. The content of each sub-node is defined by the
> +              standard binding for regulators; see regulator.txt.

You should describe which regulators exist for the device.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)