linux-kernel - Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hsh04c28h.wl-tiwai@suse.de>
Date:   Tue, 13 Nov 2018 18:32:30 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Ayman Bagabas" <ayman.bagabas@...il.com>
Cc:     <alsa-devel@...a-project.org>, "Hui Wang" <hui.wang@...onical.com>,
        "Andy Shevchenko" <andy@...radead.org>,
        "Darren Hart" <dvhart@...radead.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Kailang Yang" <kailang@...ltek.com>,
        <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED

On Sun, 11 Nov 2018 20:02:45 +0100,
Ayman Bagabas wrote:
> 
> Some of Huawei laptops come with a LED in the micmute key. This patch
> enables and disable this LED accordingly.

disable what?

> This enables micmute LED for:
> 1. Matebook X (19e5:3200), (19e5:3201)
> 2. Matebook X Pro (19e5:3204)
> 
> Signed-off-by: Ayman Bagabas <ayman.bagabas@...il.com>

The code changes are mostly OK.  Just a minor nitpicking:

> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
>  /* for alc295_fixup_hp_top_speakers */
>  #include "hp_x360_helper.c"
>  
> +/* for alc_fixup_huawei_micmute_led */

This should be alc_fixup_huawei_wmi */

With that fix,
  Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi