linux-kernel - Re: [PATCH] mtd: spi-nor: Add 4B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181114150123.65623741@bbrezillon>
Date:   Wed, 14 Nov 2018 15:01:23 +0100
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Liu Xiang <liu.xiang6@....com.cn>
Cc:     linux-mtd@...ts.infradead.org, marek.vasut@...il.com,
        richard@....at, linux-kernel@...r.kernel.org,
        liuxiang_1999@....com, computersforpeace@...il.com,
        dwmw2@...radead.org, Tudor Ambarus <tudor.ambarus@...rochip.com>
Subject: Re: [PATCH] mtd: spi-nor: Add 4B_OPCODES flag to is25lp256

On Wed, 14 Nov 2018 20:55:18 +0800
Liu Xiang <liu.xiang6@....com.cn> wrote:

> The is25lp256 supports 4-byte opcodes and quad output.
> 
> Suggested-by: Boris Brezillon <boris.brezillon@...tlin.com>
> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>

This one looks good. Tudor, can you have a look?

> ---
>  drivers/mtd/spi-nor/spi-nor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 3e54e31..3eba13a 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1357,7 +1357,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
>  	{ "is25lp128",  INFO(0x9d6018, 0, 64 * 1024, 256,
>  			SECT_4K | SPI_NOR_DUAL_READ) },
>  	{ "is25lp256",  INFO(0x9d6019, 0, 64 * 1024, 512,
> -			SECT_4K | SPI_NOR_DUAL_READ) },
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
>  	{ "is25wp032",  INFO(0x9d7016, 0, 64 * 1024,  64,
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ "is25wp064",  INFO(0x9d7017, 0, 64 * 1024, 128,