linux-kernel - Re: [PATCH v7 03/13] arch/x86: Re-arrange RDT init code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e00c50de-f24e-5ff4-6a5b-0e8e0b918ddb@amd.com>
Date:   Wed, 14 Nov 2018 20:07:07 +0000
From:   "Moger, Babu" <Babu.Moger@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "corbet@....net" <corbet@....net>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "reinette.chatre@...el.com" <reinette.chatre@...el.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "qianyue.zj@...baba-inc.com" <qianyue.zj@...baba-inc.com>,
        "xiaochen.shen@...el.com" <xiaochen.shen@...el.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Singh, Brijesh" <brijesh.singh@....com>,
        "Hurwitz, Sherry" <sherry.hurwitz@....com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "luto@...nel.org" <luto@...nel.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "jannh@...gle.com" <jannh@...gle.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "rian@...m.mit.edu" <rian@...m.mit.edu>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v7 03/13] arch/x86: Re-arrange RDT init code

Boris,

On 11/14/18 1:05 PM, Borislav Petkov wrote:
> On Fri, Nov 09, 2018 at 08:52:29PM +0000, Moger, Babu wrote:
>> Separate the call sequence for rdt_quirks and MBA feature.
>> This is in preparation to handle vendor differences in these
>> call sequences.
>>
>> Signed-off-by: Babu Moger <babu.moger@....com>
>> ---
>>  arch/x86/kernel/cpu/resctrl.c | 29 +++++++++++++++++++++++------
>>  1 file changed, 23 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl.c b/arch/x86/kernel/cpu/resctrl.c
>> index 5d526dc45751..fd5320dddddc 100644
>> --- a/arch/x86/kernel/cpu/resctrl.c
>> +++ b/arch/x86/kernel/cpu/resctrl.c
>> @@ -794,6 +794,16 @@ static bool __init rdt_cpu_has(int flag)
>>  	return ret;
>>  }
>>  
>> +static __init bool rdt_mba_config(void)
>> +{
>> +	if (rdt_cpu_has(X86_FEATURE_MBA)) {
>> +		if (rdt_get_mem_config(&rdt_resources_all[RDT_RESOURCE_MBA]))
>> +			return true;
> 
> Or simpler:
> 
>         if (rdt_cpu_has(X86_FEATURE_MBA))
>                 return rdt_get_mem_config(&rdt_resources_all[RDT_RESOURCE_MBA]);
> 
>         return false;
> 
> as rdt_get_mem_config() already returns bool.
> 

Yes. We could do that. Will modify it.