linux-kernel - Re: [GIT PULL] PCI fixes for v4.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181115155418.GA25764@pure.paranoia.local>
Date:   Thu, 15 Nov 2018 10:54:18 -0500
From:   Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Borislav Petkov <bp@...en8.de>, pr-tracker-bot@...nel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Thomas Lendacky <Thomas.Lendacky@....com>,
        Ingo Molnar <mingo@...nel.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Martin Hundebøll <martin@...nix.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org
Subject: Re: [GIT PULL] PCI fixes for v4.20

On Thu, Nov 15, 2018 at 09:03:21AM -0600, Bjorn Helgaas wrote:
> > You didn't really do anything wrong. In *general* I prefer to see
> > public URLs if they are sent to public lists, so if you're cc'ing
> > something to LKML, I would generally expect the pull request to have a
> > public URL like https://git.kernel.org/ instead of a private ssh:// URL
> > that is only accessible to people with a kernel.org account.
> > 
> > That's basically all there is to it. It doesn't *really* matter, since
> > Linus is the one who will be merging the actual pull request, and he
> > certainly has access to internal ssh:// URLs. However, in case someone
> > else was interested in reviewing the pull request, it would be more
> > friendly to have a public URL for them.
> 
> OK, I think I'll remove the insteadOf chunk from my .gitconfig.  Should
> https://korg.wiki.kernel.org/userdoc/gitolite be updated to remove or
> expand that recommendation?  The only reason I added insteadOf in the first
> place was because it sounded like a security improvement.

It is. Does adding the insteadOf rules result in ssh:// URLs when using
git-request-pull? I didn't expect that it would.

-K