[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181115150321.GB207836@google.com>
Date: Thu, 15 Nov 2018 09:03:21 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Borislav Petkov <bp@...en8.de>, pr-tracker-bot@...nel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Thomas Lendacky <Thomas.Lendacky@....com>,
Ingo Molnar <mingo@...nel.org>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Thomas Gleixner <tglx@...utronix.de>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Martin Hundebøll <martin@...nix.com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org
Subject: Re: [GIT PULL] PCI fixes for v4.20
On Thu, Nov 15, 2018 at 02:53:30AM -0500, Konstantin Ryabitsev wrote:
> On Thu, Nov 15, 2018 at 01:12:53AM -0600, Bjorn Helgaas wrote:
> > > and I kinda see the point of maybe not having your ssh username in the
> > > URL. Not that it is a big deal for us, k.org users though.
> >
> > Sorry, I don't understand the problem. I have this in my .gitconfig:
> >
> > [url "ssh://git@...olite.kernel.org"]
> > insteadOf = https://git.kernel.org
> > insteadOf = http://git.kernel.org
> > insteadOf = git://git.kernel.org
> >
> > because I thought that was the recommended way (see the end of
> > https://korg.wiki.kernel.org/userdoc/gitolite). But that also makes my
> > request-pull:
> >
> > $ git request-pull origin/master git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci-v4.20-fixes-1
> >
> > generate the ssh URL above. If I remove the insteadOf stuff from
> > .gitconfig, request-pull produces this instead:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-v4.20-fixes-1
> >
> > I'm happy to do either; just tell me which :)
>
> You didn't really do anything wrong. In *general* I prefer to see
> public URLs if they are sent to public lists, so if you're cc'ing
> something to LKML, I would generally expect the pull request to have a
> public URL like https://git.kernel.org/ instead of a private ssh:// URL
> that is only accessible to people with a kernel.org account.
>
> That's basically all there is to it. It doesn't *really* matter, since
> Linus is the one who will be merging the actual pull request, and he
> certainly has access to internal ssh:// URLs. However, in case someone
> else was interested in reviewing the pull request, it would be more
> friendly to have a public URL for them.
OK, I think I'll remove the insteadOf chunk from my .gitconfig. Should
https://korg.wiki.kernel.org/userdoc/gitolite be updated to remove or
expand that recommendation? The only reason I added insteadOf in the first
place was because it sounded like a security improvement.
Bjorn
Powered by blists - more mailing lists