linux-kernel - Re: [PATCH v2 3/5] mips: remove syscall table entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181119222924.ybnl7qe4hobud5fb@pburton-laptop>
Date:   Mon, 19 Nov 2018 22:29:29 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Firoz Khan <firoz.khan@...aro.org>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        "y2038@...ts.linaro.org" <y2038@...ts.linaro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "deepa.kernel@...il.com" <deepa.kernel@...il.com>,
        "marcin.juszkiewicz@...aro.org" <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v2 3/5] mips: remove syscall table entries

Hi Firoz,

On Thu, Nov 15, 2018 at 11:44:19AM +0530, Firoz Khan wrote:
> diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
> index a9b895f..4eee437 100644
> --- a/arch/mips/kernel/scall32-o32.S
> +++ b/arch/mips/kernel/scall32-o32.S
> @@ -208,6 +208,18 @@ einval: li	v0, -ENOSYS
>  	jr	ra
>  	END(sys_syscall)
>  
> +#ifdef CONFIG_MIPS_MT_FPAFF
> +	/*
> +	 * For FPU affinity scheduling on MIPS MT processors, we need to
> +	 * intercept sys_sched_xxxaffinity() calls until we get a proper hook
> +	 * in kernel/sched/core.c.  Considered only temporary we only support
> +	 * these hooks for the 32-bit kernel - there is no MIPS64 MT processor
> +	 * atm.
> +	 */
> +#define mipsmt_sys_sched_setaffinity sys_sched_setaffinity
> +#define mipsmt_sys_sched_getaffinity sys_sched_getaffinity

Is this backwards? ie. should it be:

    #define sys_sched_setaffinity mipsmt_sys_sched_setaffinity
    #define sys_sched_getaffinity mipsmt_sys_sched_getaffinity

?

I don't see how the mipsmt_* functions will ever be used after this
patch.

Thanks,
    Paul

> +#endif /* CONFIG_MIPS_MT_FPAFF */
> +
>  	.align	2
>  	.type	sys_call_table, @object
>  EXPORT(sys_call_table)
> @@ -450,20 +462,8 @@ EXPORT(sys_call_table)
>  	PTR	sys_tkill
>  	PTR	sys_sendfile64
>  	PTR	sys_futex
> -#ifdef CONFIG_MIPS_MT_FPAFF
> -	/*
> -	 * For FPU affinity scheduling on MIPS MT processors, we need to
> -	 * intercept sys_sched_xxxaffinity() calls until we get a proper hook
> -	 * in kernel/sched/core.c.  Considered only temporary we only support
> -	 * these hooks for the 32-bit kernel - there is no MIPS64 MT processor
> -	 * atm.
> -	 */
> -	PTR	mipsmt_sys_sched_setaffinity
> -	PTR	mipsmt_sys_sched_getaffinity
> -#else
>  	PTR	sys_sched_setaffinity
>  	PTR	sys_sched_getaffinity		/* 4240 */
> -#endif /* CONFIG_MIPS_MT_FPAFF */
>  	PTR	sys_io_setup
>  	PTR	sys_io_destroy
>  	PTR	sys_io_getevents
> -- 
> 1.9.1
>