linux-kernel - Re: [PATCH v2 4/5] mips: add system call table generation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181119223524.gsvjkf5v24ic7ilj@pburton-laptop>
Date:   Mon, 19 Nov 2018 22:35:25 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Firoz Khan <firoz.khan@...aro.org>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        "y2038@...ts.linaro.org" <y2038@...ts.linaro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "deepa.kernel@...il.com" <deepa.kernel@...il.com>,
        "marcin.juszkiewicz@...aro.org" <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v2 4/5] mips: add system call table generation support

Hi Firoz,

On Thu, Nov 15, 2018 at 11:44:20AM +0530, Firoz Khan wrote:
> diff --git a/arch/mips/kernel/syscalls/Makefile b/arch/mips/kernel/syscalls/Makefile
> new file mode 100644
> index 0000000..dc6bbb1
> --- /dev/null
> +++ b/arch/mips/kernel/syscalls/Makefile
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: GPL-2.0
> +kapi := arch/$(SRCARCH)/include/generated/asm
> +uapi := arch/$(SRCARCH)/include/generated/uapi/asm
> +
> +_dummy := $(shell [ -d '$(uapi)' ] || mkdir -p '$(uapi)')	\
> +	  $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)')
> +
> +syscallo32 := $(srctree)/$(src)/syscall_o32.tbl
> +syscall64 := $(srctree)/$(src)/syscall_64.tbl
> +syscalln32 := $(srctree)/$(src)/syscall_n32.tbl
> +syshdr := $(srctree)/$(src)/syscallhdr.sh
> +systbl := $(srctree)/$(src)/syscalltbl.sh

Could we go with 'n64' instead of just '64'?

When we get nanoMIPS support we'll be introducing the p32 ABI, and
there's a reasonable chance that the equivalent p64 ABI may come along
in the future. Using 'n64' now would avoid confusion in that case where
we may have 2 different 64-bit ABIs.

Thanks,
    Paul