linux-kernel - Re: [PATCH v2] openrisc: make function cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQxuciujLq4iu4AaN17YyfVzzwTVdcZRamxEfFY8tA5Sg@mail.gmail.com>
Date:   Mon, 19 Nov 2018 23:41:25 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Changbin Du <changbin.du@...il.com>
Cc:     Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Stafford Horne <shorne@...il.com>,
        openrisc@...ts.librecores.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] openrisc: make function cache_loop() inline

On Mon, Nov 19, 2018 at 8:31 PM Changbin Du <changbin.du@...il.com> wrote:
>
> Hi, Yamada,
> Could you add this patch to your kbuild tree? Horne already acked it.
>
> On Thu, Nov 15, 2018 at 07:08:56AM +0800, Changbin Du wrote:
> > The third operand of mtspr instruction must be a constant. To guarantee
> > this condition, function cache_loop() which uses macro mtspr() must be
> > inlined. So let's force it as 'inline'. This is to fix compiling error with
> > new option CONFIG_NO_AUTO_INLINE.
> >
> > In file included from arch/openrisc/mm/cache.c:17:0:
> > arch/openrisc/mm/cache.c: In function 'cache_loop':
> > arch/openrisc/include/asm/spr.h:20:27: warning: asm operand 0 probably doesn't match constraints
> >                               ^
> > arch/openrisc/mm/cache.c:29:3: note: in expansion of macro 'mtspr'
> >       mtspr(reg, line);
> >       ^~~~~
> > arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'
> >
> > Signed-off-by: Changbin Du <changbin.du@...il.com>
> > Reported-by: kbuild test robot <lkp@...el.com>
> > Cc: Stafford Horne <shorne@...il.com>
> > Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > Acked-by: Stafford Horne <shorne@...il.com>


Now applied to linux-kbuild.
Thanks!

> > ---
> >  arch/openrisc/mm/cache.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/openrisc/mm/cache.c b/arch/openrisc/mm/cache.c
> > index b747bf1fc1b6..4a4b2b6e006b 100644
> > --- a/arch/openrisc/mm/cache.c
> > +++ b/arch/openrisc/mm/cache.c
> > @@ -20,7 +20,7 @@
> >  #include <asm/cacheflush.h>
> >  #include <asm/tlbflush.h>
> >
> > -static void cache_loop(struct page *page, const unsigned int reg)
> > +static inline void cache_loop(struct page *page, const unsigned int reg)
> >  {
> >       unsigned long paddr = page_to_pfn(page) << PAGE_SHIFT;
> >       unsigned long line = paddr & ~(L1_CACHE_BYTES - 1);
> > --
> > 2.17.1
> >
>
> --
> Cheers,
> Changbin Du



-- 
Best Regards
Masahiro Yamada