linux-kernel - Re: [PATCH v5] tpm: add support for partial reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Nov 2018 10:36:14 -0800
From:   Tadeusz Struk <tadeusz.struk@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] tpm: add support for partial reads

On 11/20/18 4:48 AM, Jarkko Sakkinen wrote:
>> +	/* Holds the resul of the last successful call to tpm_transmit() */
> This comment is cruft.

Do you want me to remove it? This is the comment you proposed.

> 
>> +	size_t response_length;
> data_pending would be now perfectly fine name now that we concluded
> that the original length is not needed to be stored. Better than this
> as once you decrease it the variable name and contents mismatch.
> 

Can we finally agree on something? We have changed three times already.
response_length is exactly what it is and data_pending is a bit vague.

>> +	/* Becomes true when the response (or part of it) is consumed */
>> +	bool response_read;
> /* Tell whether response been consumed (read at least once). */
> 
Ok I'll update the comment.

-- 
Tadeusz