linux-kernel - Re: [PATCH v5] tpm: add support for partial reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181120230759.GF8391@linux.intel.com>
Date:   Wed, 21 Nov 2018 01:07:59 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Tadeusz Struk <tadeusz.struk@...el.com>
Cc:     jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] tpm: add support for partial reads

On Tue, Nov 20, 2018 at 10:36:14AM -0800, Tadeusz Struk wrote:
> On 11/20/18 4:48 AM, Jarkko Sakkinen wrote:
> >> +	/* Holds the resul of the last successful call to tpm_transmit() */
> > This comment is cruft.
> 
> Do you want me to remove it? This is the comment you proposed.

As I explained before it made sense before you made the remark that
it can only get positive values i.e. the length.

> > data_pending would be now perfectly fine name now that we concluded
> > that the original length is not needed to be stored. Better than this
> > as once you decrease it the variable name and contents mismatch.
> > 
> 
> Can we finally agree on something? We have changed three times already.
> response_length is exactly what it is and data_pending is a bit vague.

You are correct in this one. If I remember right, I finally proposed
'response_pending' because 'data_pending' is really vague. For me
'response_length' is just fine too.

If you see problem in my review comment or inconsistency or whatever,
please just state it. I will listen. When you multitask between patch
reviews etc. forgetting stuff is not unheard.

And seriously, 5th iteration is not alot. User space facing changes
need alot of consideration and as uncluttered code change as possible.

/Jarkko