linux-kernel - Re: [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Nov 2018 11:36:09 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to
 temp-alarm node

Hi,

On Tue, Nov 20, 2018 at 10:21 AM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> On Thu, Sep 27, 2018 at 02:22:53PM -0700, Matthias Kaehlcke wrote:
> > The temperature information from the temp-alarm block itself is very
> > coarse ("temperature is above/below trip points"). Provide the driver
> > with the die temperature channel of the ADC on the PMIC for more precise
> > readings.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> > ---
> > - based on agross/for-next (7a002fe0179c "Merge branch
> >   'defconfig-for-4.20' into all-for-4.20-redo"))
> > - depends on e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
> >   from IIO pull request:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-4.20a
> > - to work properly https://patchwork.kernel.org/patch/10594491/ is
> >   needed
> > ---
> >  arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > index 048f19fa0150..fab5a826fb01 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > @@ -58,6 +58,8 @@
> >                       compatible = "qcom,spmi-temp-alarm";
> >                       reg = <0x2400>;
> >                       interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>;
> > +                     io-channels = <&pm8998_adc ADC5_DIE_TEMP>;
> > +                     io-channel-names = "thermal";
> >                       #thermal-sensor-cells = <0>;
> >               };
> >
>
> I think this should be ready to land in for-next now that "arm64: dts:
> qcom: pm8998: Add die temperature channel node to the ADC"
> (a789fd0bab57) has been added.

Agreed and this matches my understanding of how things are supposed to
work.  FWIW:

Reviewed-by: Douglas Anderson <dianders@...omium.org>