linux-kernel - Re: [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e337e772-5581-c225-e1c1-58fa6d285988@ti.com>
Date:   Tue, 20 Nov 2018 10:31:35 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Faiz Abbas <faiz_abbas@...com>, <linux-kernel@...r.kernel.org>,
        <linux-mmc@...r.kernel.org>
CC:     <ulf.hansson@...aro.org>, <adrian.hunter@...el.com>
Subject: Re: [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure
 assignments



On 19/11/18 4:46 PM, Faiz Abbas wrote:
> The sdhci_execute_tuning() function has assignment of
> private pointers multiple times. Remove the redundant assignment.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@...com>

Acked-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>   drivers/mmc/host/sdhci-omap.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index bf268b38ddc8..b3cb39d0db6f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -295,10 +295,6 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode)
>   	int ret = 0;
>   	u32 reg;
>   
> -	pltfm_host = sdhci_priv(host);
> -	omap_host = sdhci_pltfm_priv(pltfm_host);
> -	dev = omap_host->dev;
> -
>   	/* clock tuning is not needed for upto 52MHz */
>   	if (ios->clock <= 52000000)
>   		return 0;
>