linux-kernel - Re: [RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of offlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcd55324-1dc9-904e-d457-ebce7684712f@redhat.com>
Date:   Tue, 20 Nov 2018 15:34:49 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <OSalvador@...e.com>,
        Pavel Tatashin <pasha.tatashin@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of
 offlining

On 20.11.18 15:34, Michal Hocko wrote:
> On Tue 20-11-18 15:26:43, David Hildenbrand wrote:
> [...]
>>> +	do {
>>> +		for (pfn = start_pfn; pfn;)
>>> +		{
>>
>> { on a new line looks weird.
>>
>>> +			/* start memory hot removal */
>>> +			ret = -EINTR;
>>
>> I think we can move that into the "if (signal_pending(current))"
>>
>> (if my eyes are not wrong, this will not be touched otherwise)
> 
> Better?
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 9cd161db3061..6bc3aee30f5e 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1592,11 +1592,10 @@ static int __ref __offline_pages(unsigned long start_pfn,
>  	}
>  
>  	do {
> -		for (pfn = start_pfn; pfn;)
> -		{
> +		for (pfn = start_pfn; pfn;) {
>  			/* start memory hot removal */
> -			ret = -EINTR;
>  			if (signal_pending(current)) {
> +				ret = -EINTR;
>  				reason = "signal backoff";
>  				goto failed_removal_isolated;
>  			}
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

:)

-- 

Thanks,

David / dhildenb