linux-kernel - Re: [PATCH] watchdog: cpwd: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8abef7ab-1d77-cf88-748c-11e54c760f34@roeck-us.net>
Date:   Tue, 20 Nov 2018 06:34:56 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Yangtao Li <tiny.windzz@...il.com>, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: cpwd: add of_node_put()

On 11/20/18 5:23 AM, Yangtao Li wrote:
> use of_node_put() to release the refcount.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>   drivers/watchdog/cpwd.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
> index aee0b25cf10d..d3a81642ada5 100644
> --- a/drivers/watchdog/cpwd.c
> +++ b/drivers/watchdog/cpwd.c
> @@ -617,6 +617,7 @@ static int cpwd_probe(struct platform_device *op)
>   
>   	platform_set_drvdata(op, p);
>   	cpwd_device = p;
> +	of_node_put(options);

It would be better to do that right after its last use to also cover
error handling.

Guenter

>   	return 0;
>   
>   out_unregister:
>