linux-kernel - Re: [PATCH] watchdog: cpwd: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEExFWv-iarJbgXEN78P5BjvzRqnHoLgnjnV9YZU4hKPcT4e9g@mail.gmail.com>
Date:   Tue, 20 Nov 2018 22:44:30 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: cpwd: add of_node_put()

On Tue, Nov 20, 2018 at 10:34 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 11/20/18 5:23 AM, Yangtao Li wrote:
> > use of_node_put() to release the refcount.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> > ---
> >   drivers/watchdog/cpwd.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
> > index aee0b25cf10d..d3a81642ada5 100644
> > --- a/drivers/watchdog/cpwd.c
> > +++ b/drivers/watchdog/cpwd.c
> > @@ -617,6 +617,7 @@ static int cpwd_probe(struct platform_device *op)
> >
> >       platform_set_drvdata(op, p);
> >       cpwd_device = p;
> > +     of_node_put(options);
>
> It would be better to do that right after its last use to also cover
> error handling.
>
> Guenter
>
> >       return 0;
> >
> >   out_unregister:
> >
>
Hi Guenter：

Yes, you're right. I will send the second version right away.

Yours,
    Yangtao